fix: use correct start dates on omnichannel reports #35100
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 7c7124e The changes in this PR will be included in the next version bump. This PR includes changesets to release 35 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Looks like this PR is ready to merge! 🎉 |
Contributor
|
Member
Author
As expected the test is failing without the fix
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #35100 +/- ##
===========================================
- Coverage 59.21% 59.21% -0.01%
===========================================
Files 2824 2824
Lines 67995 67985 -10
Branches 15123 15121 -2
===========================================
- Hits 40263 40255 -8
Misses 24902 24902
+ Partials 2830 2828 -2
Flags with carried forward coverage won't be shown. Click here to find out more. |
gabriellsh
previously approved these changes
Feb 3, 2025
aleksandernsilva
requested changes
Feb 4, 2025
Contributor
aleksandernsilva
left a comment
aleksandernsilva
left a comment
There was a problem hiding this comment.
- This code is shared with the Engagement Dashboard, so I recommend taking a look there to see if everything is working as it should.
- Considering the distinction between utc+0 and local time utc, it might be a good idea to test the edge scenario were changing this flag causes the
startand/orenddates to differ.
PS.: I tried running the tests locally and they were not passing, but CI seems fine 🤔
apps/meteor/client/components/dashboards/getClosedPeriod.spec.ts
Outdated
Show resolved
Hide resolved
Member
Author
They are only using the values from |
aleksandernsilva
previously approved these changes
Feb 4, 2025
KevLehman
previously approved these changes
Feb 6, 2025
Member
KevLehman
left a comment
KevLehman
left a comment
There was a problem hiding this comment.
Removing the omni review :)
jessicaschelly
added
the
stat: QA assured
KevLehman
approved these changes
Feb 10, 2025
gabriellsh
approved these changes
Feb 10, 2025
dionisio-bot
bot
added
the
stat: ready to merge
Member
Author
|
/patch |
Member
|
/bark |
Contributor
|
AU AU |
Member
|
/patch |
Contributor
|
Pull request #35212 added to Project: "undefined" |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
The omnichannel reports page was getting data for one day earlier than supposed in any option that required a date that starts at the start of the month
Issue(s)
CORE-972
Steps to test or reproduce
Further comments